Codecov Report

Attention: Patch coverage is 77.14286% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (465312b) to head (0d90ff9).
Report is 13 commits behind head on master.

@@            Coverage Diff             @@
##           master    #1401      +/-   ##
==========================================
- Coverage   75.02%   75.02%   -0.01%     
==========================================
  Files         157      157              
  Lines       18146    18206      +60     
==========================================
+ Hits        13614    13659      +45     
- Misses       3409     3420      +11     
- Partials     1123     1127       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

What is your reasoning for having new different keys in yaml for e.g rootDir vs root_dir? While i appreciate that yaml will be the default moving forward, having two different keys can cause confusion and I see little motivation for making a breaking change here

I was using the same syntax as in json, then I realized that snake case is recommended.
Since aptly condif show -yaml will convert existing json config, maybe it is not such a big migration (albeit the documentation comments will be missing). Also, the migration is optional, the json config is still valid and used by aptly.

we can still go with the json syntax if that is preferred.

Please vote for default (newly created) aptly config file to be:

• 👍: yaml with snake_case (root_dir, current)
• 🎉: yaml with same fields as json config (rootDir)
• 🚀: json with documentation comments
• 😕: stay with current json config, undocumented

snake case for consistency; btw snake type is python friendly ;)